-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fsevents2 the default implementation on macOS #623
Comments
Uh, this would mean depending on PyObjC which is quite a heavy dependency. It's effectively outsourcing our single extension module to a dependency which covers the entire macOS API. If you really want to get rid of |
Of course, given what was done lastly, there is no need to change anything. The C code is quite robust and we have more contributors knowing its internals. And we have wheels for all platforms. So my initial concerns are no longer valid. What could be interesting, for the future, may be to port |
Thanks for the update, this sounds good to me. I just stumbled upon this issue when considering to port the changes from #815 to |
The primary idea is to get ride of the C extension on macOS.
There is some work on
fsevents2
that is isfsevents
using PyObjC. Current tests are disabled, and will be fixed with #546.At term the goal is to remove
fsevents.py
andwatchdog_fsevents.c
; and renamefsevents2.py
tofsevents.py
. Afsevents2.py
will be kept for compatibility and display a deprecation warning.This will allow us to publish one wheel for every platform (#428) and fix a lot of compilation errors happening from time to time.
This issue is here to track the remaining tasks that we are not yet aware.
The text was updated successfully, but these errors were encountered: