-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto restart in watchdog==2.1.6 #855
Comments
Maybe related to #836, would you mind to have a quick look @lorenzobn 🙏 ? |
Did some poking around, and maybe this will help. I traced it somewhat to line 174 def start(self):
# windows doesn't have setsid
self.process = subprocess.Popen(self.command, preexec_fn=getattr(os, 'setsid', None)) Where Also getting this error, but with
Reverting to 2.1.5 fixes this for now. |
I'll do it as soon as I can 👍 |
I tried to reproduce the errors reported by @Pirate-Pete and @dtcooper on watchdog 2.16. Unfortunately, I wasn't able to replicate them. |
that's can be easily reproduced in docker by using python:3.9.6-slim image in docker-compose file I have tried like this:
|
@ildarworld Do you have a screenshot or something about the error? Is it a |
Hmm I cannot reproduce either using watchmedo 2.1.6, and unreleased, versions. Using Python 3.9.9 🤔 |
Hi, I have the same problem with 2.1.6., reverting to 2.1.5 makes it work again (probably related to getting rid of argh dependency in 2.1.6, and somewhat different behaviour with current parser).
I also had some issue with option arguments that did not expect any value to expect it in 2.1.6 (probably due to the same reason):
Python version is 3.9.8, OS is FreeBSD, command line I'm using is:
|
Any help needed to reproduce this? Error
Python version
Watchmedo version
|
This may be caused by using "command" both as the name for the argparse sub-parsers destination (watchmedo.py line 71) as well as the command to run (line 524). Note that the same is true for |
I am on it! |
Fixed with #887. |
I am still unable to reproduce the original issue with Python 3.10.4 and watchdog 2.1.7 (and unreleased). |
OK I finally reproduced on Python 3.9.8. What whatever magical reason, the bug is not triggered on Python 3.10. Working on a fix, thanks to @taleinat for the hint ;) |
Could someone confirm that the version from the |
Hey dawgs,
There appears to be an issue with v2.1.6 specific to having a
auto-restart
flag when initiatingwatchdog
using the following command:watchmedo auto-restart -- python -u some_python_file.py
Here is the error from the console:
![image](https://user-images.githubusercontent.com/75047122/141190666-1f10f93d-0c43-40d2-976a-82659f64d424.png)
Reverting to
2.1.5
fixed the issue. Hopefully the issue will be resolved in the upcoming release.Cheers,
The text was updated successfully, but these errors were encountered: