Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Object elements inserted using javascript after page loads not reported in the matrix #176

Closed
my-password-is-password opened this issue Jan 30, 2014 · 10 comments

Comments

@my-password-is-password
Copy link
Contributor

  1. Go to http://rutube.ru/video/embed/6781135
  2. Allow scripts for rutube.ru
  3. Refresh

If you have click-to-play enabled you will see "Click to run Adobe Flash Player". If not inspect elements and you'll see there's an object element but in the matrix its blank under the plugin column for rutube.ru.

I think after the page loads, the object is inserted with the embedSWF function in http://rutube.ru/player/player.js

@gorhill
Copy link
Owner

gorhill commented Jan 30, 2014

Never mind, I see the problem now.

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

Looks like your suggestion to listen to DOM changes is even more relevant with this bug.

@my-password-is-password
Copy link
Contributor Author

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

I did mess with mutation-summary on 0.7.9.2.

Your link doesn't work, "Page not found". In any case, I already have something working here.

@my-password-is-password
Copy link
Contributor Author

I uploaded it to a new place. I had put it in /dist and it messed up the pull request I wanted to do. Does the new link work for you?

https://github.com/my-password-is-password/stuff/blob/master/httpswitchboard_0.7.9.2_with_mutation-summary.zip

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

Fixed in 4042410.

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

Yes the link works now.

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

if ( ! /^https?:\/\/./.test(window.location.href) )

Ah yes, I need to revise that to avoid the big block. This is a remnant of when I was using chrome.tabs.executeScript, in which case the last executed javascript instruction was very important.

@my-password-is-password
Copy link
Contributor Author

Cool, its working. Thanks

@gorhill gorhill closed this as completed Jan 31, 2014
@gorhill
Copy link
Owner

gorhill commented Feb 4, 2014

Found we can't count on the tag name to be already normalized to upper case, had to explicitly normalize it in 20a2313.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants