Skip to content

Commit

Permalink
Add support for application/x-javascript in replace= option
Browse files Browse the repository at this point in the history 
Related issue:
uBlockOrigin/uAssets#5090
  • Loading branch information
@gorhill
gorhill committed Dec 21, 2023
1 parent c692be3 commit abeadf1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/js/traffic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,7 @@ const bodyFilterer = (( ) => {
'application/vnd.api+json',
'application/vnd.apple.mpegurl',
'application/vnd.apple.mpegurl.audio',
'application/x-javascript',
'application/x-mpegurl',
'application/xhtml+xml',
'application/xml',
Expand Down

6 comments on commit abeadf1

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add MIME type : text/javascript - https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#textjavascript

@gorhill
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already supported.

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean at abeadf1#diff-35c32f641b370cba4a5f06018c904c27241756164dfd317fa7c5698aec08c448R707 ?

@gwarser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 930 abeadf1#diff-35c32f641b370cba4a5f06018c904c27241756164dfd317fa7c5698aec08c448R930

@peace2000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill Could this type added as well?:

application/ld+json

@gorhill
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a case justifying doing so, I want to step into code and see why it's needed with my own eyes, like the case here.

Please sign in to comment.