Skip to content

Commit

Permalink
Add warning against adding custom filters from untrusted sources
Browse files Browse the repository at this point in the history
  • Loading branch information
gorhill committed Oct 22, 2023
1 parent e33c0f9 commit f1ce3b2
Show file tree
Hide file tree
Showing 69 changed files with 273 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/1p-filters.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<div class="body">
<div id="cloudWidget" class="hide" data-cloud-entry="myFiltersPane"></div>

<p class="vverbose"><span data-i18n="1pFormatHint"></span> <a class="fa-icon info" href="https://github.com/gorhill/uBlock/wiki/Dashboard:-My-filters" target="_blank">question-circle</a></p>
<p class="vverbose"><span data-i18n="1pFormatHint"></span>&thinsp;<a class="fa-icon info" href="https://github.com/gorhill/uBlock/wiki/Dashboard:-My-filters" target="_blank">question-circle</a>&ensp;<span data-i18n="1pTrustWarning"></span></p>
<p>
<button id="userFiltersApply" class="preferred iconified" type="button" disabled><span class="fa-icon">check</span><span data-i18n="1pApplyChanges">_</span><span class="hover"></span></button>
<button id="userFiltersRevert" class="iconified" type="button" disabled><span class="fa-icon">undo</span><span data-i18n="genericRevert">_</span><span class="hover"></span></button>
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/ar/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "فلتر واحد في كل سطر. يمكن ان يكون الفلتر رابط موقع او فلتر متوافق مع EasyList-compatible. السطور المسبوقة بـ<code>!</code> سوف يتم تجاهلها.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "استيراد",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/az/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Hər sətirdə yalnız bir filtr. Bu, ya domen adı, ya da Adblock Plus formatında yazılmış filtr ola bilər. Əvvəli <code>!</code> ilə başlayan sətirlər nəzərə alınmayacaqdır.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "İdxal və əlavə et",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/be/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Адзін фільтр на радок. Фільтрам можа быць адрас сайта або сумяшчальны з EasyList фільтр. Радкі, што пачынаюцца з <code>!</code>, будуць праігнараваны.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Імпартаваць і дадаць",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/bg/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Един филтър на ред. Това може да бъде обикновен адрес или филтър, съвместим с EasyList. Редовете с представка <code>!</code> ще бъдат игнорирани.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Внасяне от файл...",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/bn/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "লাইন প্রতি একটি ফিল্টার। একটি ফিল্টার শুধু হোস্টনেম বা অ্যাডব্লক প্লাস-এর সাথে সামঞ্জস্যপূর্ণ ফিল্টার হতে পারে। <code>!</code> দিয়ে শুরু হওয়া লাইন উপেক্ষা করা হবে।",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "আমদানি করে পরিশেষে যোগ করুন",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/bs/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Jedan filter po redu. Filter može biti običan naziv domaćina/hosta ili filter kompatibilan sa EasyList-om. Redovi sa prefiksom <code>!</code> će biti ignorisani.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Uvezi i dodaj",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/ca/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Un filtre per línia. Un filtre pot ser un domini, o un filtre compatible amb l'Adblock Plus. S'ignoraran les línies amb el símbol &lsquo;!&rsquo;.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importar i annexar",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/cs/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Jeden filtr na řádek. Filtr může být prostý název hostitele nebo filtr kompatibilní s EasyList. Řádky začínající vykřičníkem <code>!</code> budou ignorovány.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importovat a připojit",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/cv/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "One filter per line. A filter can be a plain hostname, or an EasyList-compatible filter. Lines prefixed with <code>!</code> will be ignored.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Import and append",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/da/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Ét filter pr. linje. Et filter kan være et almindeligt værtsnavn eller et EasyList-kompatibelt filter. Linjer startende med <code>!</code> ignoreres.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importér og tilføj",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/de/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Ein Filter pro Zeile. Ein Filter kann ein einfacher Hostname oder ein EasyList-kompatibler Filter sein. Zeilen mit vorangestelltem <code>!</code> werden ignoriert.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importieren und anfügen …",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/el/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Ένα φίλτρο ανά γραμμή. Φίλτρο μπορεί να είναι ένα απλό όνομα κεντρικού υπολογιστή (hostname) ή ένα, συμβατό με το Adblock Plus, φίλτρο. Γραμμές με το πρόθεμα &lsquo;!&rsquo; θα παραβλέπονται.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Εισαγωγή και προσάρτηση",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "One filter per line. A filter can be a plain hostname, or an EasyList-compatible filter. Lines prefixed with <code>!</code> will be ignored.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Import and append",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/en_GB/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "One filter per line. A filter can be a plain hostname, or an EasyList-compatible filter. Lines prefixed with <code>!</code> will be ignored.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Import and append",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/eo/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Unu filtrilo por ĉiu linio. Filtrilo povas esti ordinara gastignomo aŭ Adblock Plus-kongrua filtrilo. Prefiksitaj linioj kun &lsquo;!&rsquo; estos ignorataj.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importi kaj postaldoni",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/es/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Un filtro por línea. El filtro puede ser un nombre de dominio, o un filtro compatible con EasyList. Las líneas que comiencen con <code>!</code> serán ignoradas.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importar y anexar",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/et/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Üks filter rea kohta. Filtriks võib olla tavaline hostinimi või EasyListiga ühilduv filter. Eesliitega <code>!</code> algavaid ridu eiratakse.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Impordi ja lisa",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/eu/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Iragazki bat lerroko. Iragazkia hostalari izen soila izan daiteke, edo Adblock Plusekin bateragarria den iragazki bat. Hasieran <code>!</code> duten lerroak ezikusiko dira.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Inportatu eta gehitu",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/fa/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "یک فیلتر در هر خط. یک فیلتر می تواند آدرس هاست ساده یا فیلتر سازگار با Adblock plus باشد. خطوط با پیشوند &lsquo;!&rsquo; نادیده گرفته می شوند.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "وارد کردن و الحاق",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/fi/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Yksi suodatin riviä kohden. Suodatin voi olla pelkkä osoite tai EasyList-yhteensopiva suodatin. Rivit, joiden alussa on <code>!</code>, ohitetaan.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Tuo ja lisää...",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/fil/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Isang filter kada linya. Pwedeng simpleng hostname o EasyList-compatible ang filter. Hindi papansinin ang mga linyang nagsisimula sa <code>!</code>.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "I-import at idagdag",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/fr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Une règle par ligne. Une règle peut être un simple nom d'hôte, ou encore une règle compatible EasyList. Les lignes débutant par <code>!</code> seront ignorées.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importer",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/fy/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Ien filter per rigel. In filter kin in gewoane hostnamme of in Adblock Plus-kompatibel filter wêze. Rigels begjinnend mei <code>!</code> wurde negearre.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Ymportearje en tafoegje",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/gl/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Un filtro por cada liña. O filtro pode ser un nome de servidor, ou un filtro compatible co Adblock Plus. As liñas que comecen con <code>!</code> seranche ignoradas.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importar e anexar",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/gu/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "One filter per line. A filter can be a plain hostname, or an EasyList-compatible filter. Lines prefixed with <code>!</code> will be ignored.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Import and append",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/he/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "מסנן אחד לכל שורה. המסנן יכול להיות דומיין פשוט, או מסנן התואם ל- EasyList. שורות עם קידומת <code>!</code> לא יפורשו.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "ייבא וצרף",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/hi/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "एक लाइन में एक फ़िल्टर। एक फ़िल्टर सीधा होस्टनाम, या एक Adblock Plus- योग्य फ़िल्टर हो सकता है। <code>!<code></code>से शुरू होने वाली लाइनों को नज़रअंदाज किया जायेगा।",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "इम्पोर्ट करें और जोड़ें",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/hr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Jedan filter po retku. Filter može biti običan hostname ili filter kompatibilan sa EasyList-om. Linije sa prefiksom <code>!</code> zanemarit će se.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Uvesti i dodati",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/hu/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Soronként egy szűrő. A szűrő lehet egy hostnév, vagy egy Adblock Plus kompatibilis szűrő.\nA <code>!</code> kezdetű sorok figyelmen kívül maradnak.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importál és hozzáad",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/hy/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Մեկ տողում մեկ զտիչ։ Որպես զտիչ կարող է լինել կայքի անուն կամ EasyList-համաեղելի զտիչ։ <code>! </code>-ով սկսվող տողերը կանտեսվեն։",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Ներմուծել և հավելել",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/id/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Satu filter per baris. Filter dapat berupa nama hos, atau filter yang kompatibel dengan EasyList. Baris yang diawali dengan <code>!</code> akan diabaikan.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Impor dan tambahkan",
"description": "English: Import and append"
Expand Down
4 changes: 4 additions & 0 deletions src/_locales/it/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,10 @@
"message": "Un filtro per riga. Un filtro può essere un semplice hostname, o un filtro compatibile con EasyList. Ogni riga che comincia con <code>!</code> verrà ignorata.",
"description": "Short information about how to create custom filters"
},
"1pTrustWarning": {
"message": "Do not add filters from untrusted sources.",
"description": "Warning against copy-pasting filters from random sources"
},
"1pImport": {
"message": "Importa e aggiungi",
"description": "English: Import and append"
Expand Down
Loading

2 comments on commit f1ce3b2

@u-RraaLL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering people such as myself that are using widescreen monitors - I'm not sure the plain text warning at the very end of a single line will capture enough attention.

Perhaps font-weight: bold; would be a good choice here?

Replying here because the thread is locked for me too.

@gorhill
Copy link
Owner Author

@gorhill gorhill commented on f1ce3b2 Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I was planning to use color: var(--info3-ink);, but I feared people might complain it's annoying:

image


I am going to reopen the thread with the hope no more imaginary issues will be posted to it.

Please sign in to comment.