Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Japanese] Seconds on the logger page not showing issue. #3293

Closed
eEIi0A5L opened this issue Nov 28, 2017 · 9 comments
Closed

[Japanese] Seconds on the logger page not showing issue. #3293

eEIi0A5L opened this issue Nov 28, 2017 · 9 comments

Comments

@eEIi0A5L
Copy link

Describe the issue

Seconds of the logger page is not showing on Japanese fonts. Could you expand the width of
the column a little bit? Thanks!

One or more specific URLs where the issue occurs

moz-extension://ff2815cd-8906-4f67-9cb9-ddb17fb583b8/logger-ui.html#tab_196

Screenshot in which the issue can be seen

(attached)
default

Steps for anyone to reproduce the issue

  1. Open the logger page.

Your settings

  • OS/version: Windows 10 64bit Japanese
  • Browser/version: Firefox 57
  • uBlock Origin version: 1.14.18
Your filter lists

EasyList

Your custom filters (if any)
@gorhill
Copy link
Owner

gorhill commented Nov 28, 2017

Can you tell me the font face used by the browser? (use the browser style inspector).

@eEIi0A5L
Copy link
Author

It is "Meiryo" font.
22

@yasmise
Copy link

yasmise commented Nov 29, 2017

I'm not sure I'm doing right, but changing css/logger-ui.css as follows works fine for me.

Line 122--124:

#netInspector table > colgroup > col:nth-of-type(1) {
    width: 5.2em;
    }

Line 137--139:

#netInspector table > colgroup > col:nth-of-type(6) {
    width: calc(100% - 16.2em - 20%);
    }

logger_changed

Tested with uBlock Origin 1.14.19rc2 with this change, on Firefox 57 and Chrome 62.0.3202.94, on Windows 10 Home Japanese. Font is Meiryo.

@eEIi0A5L
Copy link
Author

Works fine!

I modified uBlock Origin 1.14.18, changed css/logger-ui.css as you said above. It worked fine here!!
Thank you so much! Now I close this issue.

33

@yasmise
Copy link

yasmise commented Nov 29, 2017

Thanks for your confirmation.
But, could you re-open this issue? gorhill will close after he/she makes changes to the source code.

@eEIi0A5L
Copy link
Author

Sorry. I re-opened.

@eEIi0A5L eEIi0A5L reopened this Nov 29, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 29, 2017

The ideal fix would be one where I don't have to guess the width.

I tried width: min-content;, but unfortunately it didn't work, that would have been perfect fix because there would be no need to guess the width.

I am thinking of forcing a specific font family so that I know the width issue will no longer be an issue anywhere.

@yasmise
Copy link

yasmise commented Nov 30, 2017

Well, I played with logger-ui.css and found that this seems working.
But I couldn't tell this is expected behavior or not, so I'm feeling that "forcing a specific font" would be safer fix.

#netInspector table {
    border: 0;
    border-collapse: collapse;
    direction: ltr;
    table-layout: auto;   /***** changed from fixed to auto *****/
    width: 100%;
    }

#netInspector table > colgroup > col:nth-of-type(1) {
    width: 5em;
    }
#netInspector table > colgroup > col:nth-of-type(2) {
    width: 2.5em;
    }
/***** comment out
#netInspector table > colgroup > col:nth-of-type(3) {
    width: 20%;
    }
*/
#netInspector table > colgroup > col:nth-of-type(4) {
    width: 2.5em;
    }
#netInspector table > colgroup > col:nth-of-type(5) {
    width: 6em;
    }
/***** comment out
#netInspector table > colgroup > col:nth-of-type(6) {
    width: calc(100% - 16em - 20%);
    }
*/

/***** added *****/
#netInspector tr td:nth-of-type(3) {
    min-width: 15vw;
    max-width: 15vw;
    }
#netInspector tr td:nth-of-type(6) {
    min-width: 50vw;
    max-width: 50vw;
    }

@uBlock-user
Copy link
Contributor

Were the fonts changed for the logger page ? I'm seeing a different font in the logger on v1.14.21.101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants