Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBO's own reload button does not do a cache-invalidating reload #3408

Closed
foobar13373 opened this issue Jan 6, 2018 · 1 comment
Closed

Comments

@foobar13373
Copy link

Describe the issue

In the later versions of uBO (can't exactly say since when, just noticed this. maybe it was always this way, maybe since the webext version), on some website uBO's own reload button does not correctly reload the website.

Below you'll find an example website. This website has an image slider below its menu. If all resources are disabled by uBO (red button on "all resources" in the left column) the example website will tell you that you need JavaScript to fully use the site. If you then allow the main-domain (I tried both, the middle gray and green button in right column, to make sure it's not a filter issue) and click uBO's own reload button, the page will reload with all styles. However the image silder will still say that it's needs JavaScript - however uBO does not actually block JS, the message comes from the browser cache. Doing a Ctrl+F5 (cache-invalidating) reload, will correctly load the now working JavaScript-enabled slider.

I noticed this on some website now, so I assume this is a rather new behavior. I'm not sure if it is intented or changed in some FF / uBO version, but to me it feels wrong.

One or more specific URLs where the issue occurs

https://www.kfw.de/kfw.de.html

Steps for anyone to reproduce the issue

  1. Block everything using uBO (red button on all resources, left column)
  2. go to example website (see above)
  3. you should see unstyled content, where somewhere it says that you'll need JS enabled (German: "Tipp: Aktivieren Sie Javascript, damit Sie alle Funktionen unserer Website nutzen können.")
  4. Allow the domain (right column of uBO buttons, gray or green, for this domain)
  5. Click uBO's own reload button
  6. "JS missing" warning still appears (scroll to top to see it, it's styled now, but same text, image slider won't work)
  7. reload again using Ctrl+F5
  8. the image slider loads correctly now

Your settings

  • OS/version: Windows 10
  • Browser/version: FF 57.0.4
  • uBlock Origin version: 1.14.22
@foobar13373 foobar13373 changed the title Allowing a domain in the icon menu and then reloading seem to not do a cache-invalidating reload Allowing a domain via menu and using uBO's own reload button does not do a cache-invalidating reload Jan 6, 2018
@gorhill
Copy link
Owner

gorhill commented Jan 6, 2018

Browser issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1376932.

I won't make uBO bypass the cache by default, but I can make uBO's reload button behaves as the browser's reload button.

@gorhill gorhill closed this as completed in b7155a0 Jan 7, 2018
@gorhill gorhill changed the title Allowing a domain via menu and using uBO's own reload button does not do a cache-invalidating reload uBO's own reload button does not do a cache-invalidating reload Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants