You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Entry timestamps in the logger are incorrect when the system time zone's UTC offset is not on an hour boundary (e.g. Newfoundland Time Zone at -03:30 UTC, Nepal Standard Time at +05:45 UTC).
One or more specific URLs where the issue occurs
N/A
Screenshot in which the issue can be seen
N/A
Steps for anyone to reproduce the issue
Set the system time zone to one of the above-mentioned.
Notice the timestamps of the new logger entries (specifically the minute value) do not match the current time.
Fix seems trivial: using getUTCMinutes() rather than getMinutes() in line 546 of /src/js/logger-ui.js gives the correct timestamp, since the offset is already applied via setTime().
Your settings
[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]
Browser/version: Firefox 51, Chromium 57
uBlock Origin version: 1.10.4, 1.10.5b9
Your filter lists
N/A
Your custom filters (if any)
The text was updated successfully, but these errors were encountered:
Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md
Describe the issue
Entry timestamps in the logger are incorrect when the system time zone's UTC offset is not on an hour boundary (e.g. Newfoundland Time Zone at -03:30 UTC, Nepal Standard Time at +05:45 UTC).
One or more specific URLs where the issue occurs
N/A
Screenshot in which the issue can be seen
N/A
Steps for anyone to reproduce the issue
Fix seems trivial: using
getUTCMinutes()
rather thangetMinutes()
in line 546 of /src/js/logger-ui.js gives the correct timestamp, since the offset is already applied viasetTime()
.Your settings
[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]
Your filter lists
N/A
Your custom filters (if any)
The text was updated successfully, but these errors were encountered: