-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] When Text Inputs become focused, the highest snap point is ALWAYS expanded to #1648
Comments
Thanks for the detailed issue @calebpanza 🙌 this seemed to be a good feature request, i have drafted a new keyboard behaviour Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-11-30.at.18.57.23.mp4i will need to iron it out and submit a CR by this weekend. |
Wow this is great! Thanks so much for looking into it so quickly. Are you thinking of making this a prop that could be configured on the Bottom Sheet? If I were to have an accessory (like a button, maybe) trailing the text input on the bottom, would that element get cut off given the |
Hey @gorhom just wanted to throw this out there. I was also having an issue where every time I focused on the Text Input on Androids, the entire Bottom Sheet would dismiss. Did some digging and found this solution as an open PR. When I implemented it, it also resolved the problem that we're discussing in this issue. |
Any progress here? More than happy to jump in and help if there's a branch/PR up! |
I'm facing the exact same problem.. @calebpanza thank you so much for posting this bug.. just to confirm this is happening on IOS aswell right ? @gorhom Can we expect this to be picked up soon ? would really appreciate it :) |
@calebpanza could you test #1675, it should address the issue |
@gorhom I have tested by installing It still doesn't work.. still when text input is focused it snaps to highest snap point also now I have to explicitly pass Appreciate you looking into this so quickly :) thanks alot cc @calebpanza |
So sorry to have missed this. Was out for the holidays. I'd be happy to pull the 5.0 alpha and test this out! |
Hi, I was wondering if there was a solution to this? I'm currently on "^4.6.1" |
Bug
When building out a sheet with a Text Input, the sheet will always expand to the highest snap point when the Text Input is focused.
Environment info
Steps To Reproduce
For example, I might have a sheet with the following snap points:
[100, 'CONTENT_HEIGHT']
When I focus the Text Input, the Bottom Sheet expands to the
CONTENT_HEIGHT
.screen-20231130-120825.2.mp4
I want to be able to offer the user a chance to further expand the text input, so I update the snap points:
[100, 'CONTENT_HEIGHT', '90%']
Now, though, when I focus the Text Input, the Bottom Sheet will always expand to the
90%
.screen-20231130-120633.2.mp4
Describe what you expected to happen:
I'm expecting to be able to have the Text Input focus to the minimum required height for the size of my content unless the user specifies otherwise. The effect that I'm trying to achieve is similar to Slack's interface for text input. Some screenshots and examples are provided below.
screen-20231130-122651.2.mp4
What we're trying to achieve (this is a Figma prototype)
Reproducible sample code
I put together this repo that includes an Expo app that you can see the code examples from the recordings above. Running the app is as simple as
yarn && yarn start
and works with Expo Go.The text was updated successfully, but these errors were encountered: