Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stack behavior replace-and-dismiss #1897

Closed

Conversation

janodetzel
Copy link

I added a new stack behavior type which dismisses the previous modal instead of minimizing it.

Please provide enough information so that others can review your pull request:

Motivation

This new stack behaviour type is important to enable users to dismiss the previous modal when a different modal is opened.

@janodetzel
Copy link
Author

@gorhom can you have a look at this new stack behaviour type? Would triggering dismiss() instead of minimize() cause any problems?

@gorhom gorhom self-assigned this Aug 17, 2024
@gorhom gorhom added the v5 label Aug 17, 2024
@gorhom
Copy link
Owner

gorhom commented Aug 17, 2024

hi @janodetzel thanks for submitting this PR, i think the naming replace does not represent its functionality , might worth renaming it to stack or switch. and replace would be the present and dismiss old sheet

@EvgenMart
Copy link

@gorhom , Greetings! This may not be entirely on topic, but I would like to ask. Is there a possibility to add a current example of using BottomSheet with @react-navigation/native? The link to the example in the description is no longer valid: https://github.com/gorhom/react-native-bottom-sheet/blob/master/example/bare/src/screens/integrations/NavigatorExample.tsx

@gorhom
Copy link
Owner

gorhom commented Oct 26, 2024

@janodetzel thanks for submitting this PR, i have already introduce this feature on v5 https://gorhom.dev/react-native-bottom-sheet/modal/props#stackbehavior

@gorhom gorhom closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants