Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: You need to install FlashList first, yarn install @shopify/flash-list, js engine: hermes #1967

Closed
dannyhw opened this issue Oct 14, 2024 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@dannyhw
Copy link

dannyhw commented Oct 14, 2024

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

iOS, Android, Web

What happened?

When using version 5 without flashlist installed this error causes the app to crash

You need to install FlashList first,yarn install @shopify/flash-list, js engine: hermes

Since the files are all barrel files every file will run even if you don't import them so this would only be fixed by

removing the export from:
src/components/bottomSheetScrollable/index.ts and here src/index.ts

Reproduction steps

  • setup bottom sheet and don't install flashlist
  • import scrollable (not flashlist)
  • crashes

Reproduction sample

https://snack.expo.dev/@dannyhw/bottom-sheet---issue-reproduction-template

Relevant log output

You need to install FlashList first, `yarn install @shopify/flash-list`
  Evaluating @gorhom/bottom-sheet.js
  Evaluating App.js
  Loading App.js
@dannyhw dannyhw added the bug Something isn't working label Oct 14, 2024
Copy link

Hello @dannyhw 👋, this issue is being automatically closed and locked because it does not follow the issue template.

@github-actions github-actions bot added the invalid This doesn't seem right label Oct 14, 2024
@github-actions github-actions bot locked as spam and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant