Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider borders with style none nonexistant? #19

Open
gorn opened this issue Nov 3, 2016 · 1 comment
Open

Consider borders with style none nonexistant? #19

gorn opened this issue Nov 3, 2016 · 1 comment

Comments

@gorn
Copy link
Owner

gorn commented Nov 3, 2016

This is strange issue and I wonder what is your opinion on that.

In OpenDocument format a border can either not exist at all OR exist with style set to none.

I did not found any clue on what is the difference between these two. Now the (rather philosophical) question is what the following code should return (@cell contains a Cell object):

@cell.border_right.style = 'dotted'
@cell.border_right.width = '3pt'
@cell.border_right.color = '#112233'
p @cell.border_right.color    # => '#112233'
@cell.border_right.style = 'none'
p @cell.border_right.color    # => ??????

the color is remebered in the code but the border is nonexistant. Should it return nil or '#112233'?

@vtamara
Copy link
Contributor

vtamara commented Mar 25, 2017

IMHO it is fine that it returns #112233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants