Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improve gomega matchers #538

Closed
aelsabbahy opened this issue Jan 22, 2020 · 3 comments · Fixed by #814
Closed

Feature Request: Improve gomega matchers #538

aelsabbahy opened this issue Jan 22, 2020 · 3 comments · Fixed by #814

Comments

@aelsabbahy
Copy link
Member

aelsabbahy commented Jan 22, 2020

Describe the feature:

Improve gomega matchers.

Describe the solution you'd like

  1. Allow transforms. For example the following should work (fixes Check if param is gt than #350)
kernel-param:
  net.core.somaxconn:
    value:
      gt: 5000
  1. Add more gomega matchers, for example, the matchallelements matcher for slices.
    https://onsi.github.io/gomega/#gstruct-testing-complex-data-types
@pedroMMM
Copy link
Contributor

@aelsabbahy besides matchallelements any other matchers you have in mind?

Maybe the 2 requests should be broken into 2 different issues/PRs? If they are broken apart this could be easier to create and review as well.

@aelsabbahy
Copy link
Member Author

Yeah, they probably should be broken apart into two tickets and your ticket is the third enhancement on the gomega matchers for io.

@aelsabbahy
Copy link
Member Author

aelsabbahy commented Apr 10, 2020

@pedroMMM Finally got some time to hammer out my thoughts on this.. feels good since I've wanted to make progress on this concept forever now.

Check out the following PR: #576

For usage examples take a look at this:
https://github.com/aelsabbahy/goss/tree/add_transforms/examples

It works.. but unit tests are broken and the code is quickly thrown together and can use some love. I probably won't be available next week.. but if you're interested in this.. feel free to take my branch and run with it =)

This + Sprig + Per-package/service drivers = goss v0.4.0 milestone for me.

@aelsabbahy aelsabbahy added this to the v0.4.0 milestone May 3, 2020
@aelsabbahy aelsabbahy added the v4 label Jul 17, 2020
@aelsabbahy aelsabbahy mentioned this issue Nov 13, 2020
Closed
5 tasks
@aelsabbahy aelsabbahy mentioned this issue Jun 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants