Serve with Prometheus Output does not 503 on failed check

[jameshounshell]

Unlike the other output modes (ex: documentation/json), the prometheus output does not report 503 at /healthz when a test fails.

Is this by design? If so could something be added to the docs to say this is the exception.

Thanks in advance!

For example using this goss.yaml

file:
  /etc/nothinghere:
    exists: true

Run this command goss -g goss.yaml serve -f prometheus --format-options verbose

Then curl localhost:8080/healthz and examine the status code. Other format options return 503, while prometheus option returns 200.

[aelsabbahy]

I assume it's by design, that feature was added by @petemounce. He can probably provide more accurate information than me.

[petemounce]

Ah, I think no; that's not by design. I think outputs/prometheus.go L87 should return 1 when there are any failure outcomes vs the unconditional 0 it does now, or the -1 it does on system-error.