Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include timeout errors in junit reports. #349

Closed
sodul opened this issue Aug 2, 2023 · 1 comment · Fixed by #357
Closed

Include timeout errors in junit reports. #349

sodul opened this issue Aug 2, 2023 · 1 comment · Fixed by #357
Labels
bug Something isn't working

Comments

@sodul
Copy link

sodul commented Aug 2, 2023

We use Jenkins to parse the junit reports from gotestsum. We noticed that when a test is timedout, the junit report on Jenkins show a failure but not that it was caused by a timeout and we have to go into the console output to figure this out.

Since gotestsum should be aware that the test was aborted due to the timeout, this could be reflected in the junit report so that we can more efficiently know the actual cause in the Jenkins UI, or whatever junit presentation layer is used.

@dnephin dnephin added the bug Something isn't working label Aug 2, 2023
@sodul sodul changed the title Include timeout erros in junit reports. Include timeout errors in junit reports. Aug 3, 2023
@dnephin
Copy link
Member

dnephin commented Aug 12, 2023

Thank you for the bug report! I think this is due to the same underlying problem as #292. The go toolchain is inconsistent about where the timeout is reported (golang/go#57305).

In #298 I fixed this with a workaround for the regular output. Either that fix didn't cover the junit.xml, or maybe that fix caused it to be missing. Either way #357 seems like it should fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants