Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username and password in image url #111

Closed
Colgaton opened this issue May 16, 2020 · 4 comments · Fixed by #356
Closed

Username and password in image url #111

Colgaton opened this issue May 16, 2020 · 4 comments · Fixed by #356
Labels
a:bug Something isn't working

Comments

@Colgaton
Copy link

Colgaton commented May 16, 2020

When using markdown and sending something like below, it does not render it:

![Camera Image](https://user:pass@domain.com/abc/test.jpg)

First I thought it would be an android limitation, but it works fine in Chrome. Any idea?

@jmattheis
Copy link
Member

Looks like the library gotify uses for markdown support on android, doesn't support this by default.

@jmattheis jmattheis added the a:bug Something isn't working label May 17, 2020
@cyb3rko
Copy link
Contributor

cyb3rko commented Jun 17, 2024

After some research I've learned that the username and password in the URL are converted to an "Authorization" header.
With an OkHttp interceptor we could let the image loading library convert the username and password into an basic auth authorization header.

Is this issue still relevant?

@jmattheis
Copy link
Member

I'd say yes, as the behavior between the gotify in the browser and android shouldn't differ.

@cyb3rko
Copy link
Contributor

cyb3rko commented Jun 17, 2024

The solution was very easy and is working fine.
I will open a PR when #353 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants