Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of different calendar function without leap years #1

Open
TobiasKAndersen opened this issue May 9, 2019 · 2 comments

Comments

@TobiasKAndersen
Copy link

A scenario simulation with GOTM could be done by choosing forcing from one or several years as a period to repeat several times, thereby creating a longer scenario period built upon actual forcing data. But if the repeat period is not 4 years long, the scenario simulation will run into a problem with leaps years.
Therefore, the option of GOTM being able to run on a calendar without leap years would enable to run scenario simulations build upon repeating actual forcing data much more smoothly.

@TobiasKAndersen
Copy link
Author

As I am not a contributor I cannot add labels, but would propose the label to be #enhancement

@bolding
Copy link
Collaborator

bolding commented May 9, 2019

NetCDF has support for different calendars through the CFconventions - http://cfconventions.org/Data/cf-conventions/cf-conventions-1.6/build/cf-conventions.html#calendar.

So the main thing is changes to the GOTM time module - and support in flexible output to create files with the calendar attribute.

If we go in this direction we might consider introducing time zones as well.

The entire changes to the code is not neglible :-) And how do we treat observations with real date/time information in the case of alternative calendars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants