Weekday names should respect the first day of week

[emwee]

I want my calendar to let week starts on Monday. The API is pretty much straight-forward, but I can't get it to work.

My code:

const localeUtils = {
    formatDay: (d, locale='en') => formatDate(d, 'LLLL'),
    formatMonthTitle: (d, locale) => moment.months()[d.getMonth()],
    formatWeekdayShort: (i, locale) =>  moment.weekdaysShort()[i],
    formatWeekdayLong: (i, locale) => moment.weekdays()[i],
    getFirstDayOfWeek: (locale) => 0,
}

const Datepicker = props =>
    <DayPicker
        localeUtils={localeUtils}
    />

It doesn't matter if getFirstDayOfWeek returns 0 or 1, the first weekday is always Sunday.

I am using version 2.4.1.

[gpbl]

Hi @emwee!
Yeah that's not clear from the examples: if you want to set the first day to Monday, also your weekdays names should start on Monday.

[gpbl]

(Sorry my previous comment included a code sample that didn't work, the trick is making the weeks name array starting from monday)

[gpbl]

I'm filing this as bug as I agree it is an unexpected behavior :)

[emwee]

Alright, fixed it the way you suggested for now. Thanks! :-)

const getWeekdayByIndex = (weekdays, i) =>
    weekdays[(i + 1) < weekdays.length ? i + 1 : 0]

export const localeUtils = {
    formatDay: (d, locale='en') => formatDate(d, 'LLLL'),
    formatMonthTitle: (d, locale) => moment.months()[d.getMonth()],
    formatWeekdayShort: (i, locale) => getWeekdayByIndex(moment.weekdaysShort(), i),
    formatWeekdayLong: (i, locale) => getWeekdayByIndex(moment.weekdays(), i),
    getFirstDayOfWeek: () => 1,
}

[gpbl]

Nice !! Reopening this as i'd like to fix it in the next major release.

[emwee]

👍

[gpbl]

This has been fixed in v3 – no need anymore for the workaround above, @emwee !