Add support for handling mouse up and down on days #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpbl
requested changes
Jul 2, 2017
src/Month.js
Outdated
| @@ -54,6 +54,8 @@ export default class Month extends Component { | |||
| onDayKeyDown: PropTypes.func, | |||
| onDayMouseEnter: PropTypes.func, | |||
| onDayMouseLeave: PropTypes.func, | |||
| onDayMouseDown: PropTypes.func, | |||
| onDAyMouseUp: PropTypes.func, | |||
There was a problem hiding this comment.
✍️ This should be written onDayMouseUp (with lowercase A)
There was a problem hiding this comment.
Let me fix these items up.
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 516 516
Branches 102 102
=====================================
Hits 516 516
Continue to review full report at Codecov.
|
|
Added tests and eslint runs clean. Also added API doc. |
gpbl
approved these changes
Jul 9, 2017
|
Awesome! Thanks a lot 👍 |
|
Published as v6.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add handlers for mouseUp and mouseDown events on days. This allows one to select dates by moving the mouse over the days while holding down the mouse button.