Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed lost input focus #525

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fixed lost input focus #525

merged 1 commit into from
Oct 23, 2017

Conversation

martinmosko
Copy link

Issue:

  1. Open Firefox (its not an issue in chrome) https://codesandbox.io/s/XDAE3x0W8
  2. Click on day picker input (it shows calendar)
  3. Click on navigation bar element (next, prev or nav title elements)
  4. Main day picker input loses own focus and calendar stays open
  5. Now when you click anywhere outside of calendar. Calendar is still open but is should close.

Solution:

Looks like the problem in FF is just timing of this.input.focus(); call. This fix is solving the issue.

@gpbl
Copy link
Owner

gpbl commented Oct 23, 2017

Ah! Awesome. Maybe this fixes also #475

@gpbl gpbl added this to the v6.3.0 milestone Oct 23, 2017
@gpbl gpbl merged commit e2f9be0 into gpbl:master Oct 23, 2017
@martinmosko martinmosko deleted the input-focus-fix branch October 25, 2017 12:27
@gpbl gpbl modified the milestones: v6.3.0, v7.0.0 Nov 25, 2017
@gpbl gpbl mentioned this pull request Nov 25, 2017
Closed
@bartpeeters bartpeeters mentioned this pull request Jan 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmosko @gpbl