Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 17 support #685

Closed
catamphetamine opened this issue Apr 2, 2018 · 4 comments
Closed

React 17 support #685

catamphetamine opened this issue Apr 2, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@catamphetamine
Copy link

React 16.3 has been released deprecating componentWillReceiveProps.

I can see your code uses componentWillReceiveProps in a couple of places.
You can migrate it using https://github.com/reactjs/react-lifecycles-compat
@gpbl gpbl added good first issue Good for newcomers v:patch labels Apr 3, 2018
@gpbl gpbl mentioned this issue Apr 14, 2018
Merged
@gpbl gpbl closed this as completed in #696 Apr 14, 2018
@gpbl
Copy link
Owner

gpbl commented Apr 14, 2018

Published as v7.1.5

@catamphetamine
Copy link
Author

I think you got it all wrong.
React 16.3 deprecates componentWillReceiveProps which is being removed in React 17.
The polyfill won't transform old methods into new methods.
It works the opposite way only.

Lastly, use the polyfill to make the new lifecycles work with older versions of React

https://github.com/reactjs/react-lifecycles-compat

@catamphetamine catamphetamine mentioned this issue Apr 14, 2018
Closed
@gpbl
Copy link
Owner

gpbl commented Apr 14, 2018

ahah thanks for pointing it out it looked too easy indeed 😅

@gpbl gpbl reopened this Apr 14, 2018
@gpbl
Copy link
Owner

gpbl commented Apr 14, 2018

someone can take this up?

@gpbl gpbl mentioned this issue Apr 15, 2018
Merged
@gpbl gpbl closed this as completed in #698 Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpbl @catamphetamine