Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undefined and null as allowed modifier types #775

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

LavaToaster
Copy link
Contributor

Examples like: https://react-day-picker.js.org/examples/selected-range-enter/ show that modifiers are in fact supported as undefined or nullable. They do not work in typescript without some fair amount of work to ensure the value isn't null, when in fact the library does handle those types.

Examples like: https://react-day-picker.js.org/examples/selected-range-enter/ show that modifiers are in fact supported as undefined or nullable. They do not work in typescript without some fair amount of work to ensure the value isn't null, when in fact the library does handle those types.
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #775 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          15       15           
  Lines         646      646           
  Branches      142      142           
=======================================
  Hits          645      645           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b7855...82fd323. Read the comment docs.

@gpbl gpbl merged commit fb66e52 into gpbl:master Aug 22, 2018
@gpbl
Copy link
Owner

gpbl commented Aug 22, 2018

Thanks! We are planning a release in the next days, so stay tuned.

@LavaToaster LavaToaster deleted the patch-1 branch August 22, 2018 12:53
@LavaToaster
Copy link
Contributor Author

Ah excellent news :)

@gpbl gpbl added this to the v7.2.0 milestone Aug 27, 2018
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
Add undefined and null as allowed modifier types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants