Fix DayPickerInput classNames TS definitions #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoandf
approved these changes
Oct 3, 2018
|
Any updates here? |
|
Came here for this fix too. Looks like a PR has been open a while. @gpbl Are you still maintaining this library? |
|
@gpbl Another option would be removing the definition files from the library so we TS users can constantly update them on definitely typed. |
HNBowen
added a commit
to TurnKeyVR/react-day-picker
that referenced
this pull request
Feb 25, 2020
Implements a fix tha adds missing class names to the day picker input types. This fix was merge into the main react-day-picker fork in this PR: gpbl#796
kimamula
pushed a commit
to kimamula/react-day-picker
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
classNamesproperty for theDayPickerInputcomponent.Discussed in #759.