Add missing props from weekdayElement and caption Element

[johnjesse]

Changes:

I think the typings on captionElement and weekdayElement are wrong, and I think the documentation is wrong too. Looking at the default props that DayPicker receives, it's clear that the months weekdaysShort and weekdaysLong are passed through to those elements if they are specified on the DayPicker. This makes sense, how else will those elements be localized correctly. Therefore if I provide my own elements for the caption or weekday they'll need those props too.

They actually get them 👍 so the only thing that's missing is to update the types. which I've done

I'd also would've updated the docs, but the template advised against that. I will volunteer to update them though :).

[codecov]

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #842   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    645           
  Branches      141    141           
=====================================
  Hits          645    645

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...ecf6805. Read the comment docs.

[codecov]

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #842   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    645           
  Branches      141    141           
=====================================
  Hits          645    645

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...ecf6805. Read the comment docs.

[codecov]

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #842   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         645    645           
  Branches      141    141           
=====================================
  Hits          645    645

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ad48e...ecf6805. Read the comment docs.

[giladgray]

in props.d.ts, months is typed as a 12-element tuple:

react-day-picker/types/props.d.ts

Lines 65 to 78 in 39ad48e

	months?: [
	string,
	string,
	string,
	string,
	string,
	string,
	string,
	string,
	string,
	string,
	string,
	string
	];

think it's worth duplicating that here? or, better, making a type alias MonthsArray for that gross tuple and reusing that.

[johnjesse]

See #843 - depending on whether that is merged I'd be happy to switch this to an type alias MonthArray like you suggest

[gpbl]

Yeah it’s not that the way we are doing with those *Element props are right. Hope to fix that in the next mayor release. Thanks folks for the patience and the review!