Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabIndex to DayPickerProps #909

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Add tabIndex to DayPickerProps #909

merged 1 commit into from
Aug 3, 2019

Conversation

clarityflowers
Copy link

It looks like this is included in the propTypes for the component, but didn't get added to the typescript typings.

It looks like this is [included in the propTypes](https://github.com/gpbl/react-day-picker/blob/421af9f56b1b07ed58f864678b3bbb8617cdaff7/src/DayPicker.js#L92) for the component, but didn't get added to the typescript typings.
@codecov-io
Copy link

Codecov Report

Merging #909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #909   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421af9f...9f13f5c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jul 6, 2019

Codecov Report

Merging #909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #909   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421af9f...9f13f5c. Read the comment docs.

@gpbl
Copy link
Owner

gpbl commented Aug 3, 2019

Hey thank you for the PR! I'm trying to resume this project , sorry for the late answer.

@gpbl gpbl merged commit c7a1bce into gpbl:master Aug 3, 2019
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
It looks like this is [included in the propTypes](https://github.com/gpbl/react-day-picker/blob/421af9f56b1b07ed58f864678b3bbb8617cdaff7/src/DayPicker.js#L92) for the component, but didn't get added to the typescript typings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants