Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions node undesirable behaviors #26

Open
borupdaniel opened this issue Jan 16, 2020 · 2 comments
Open

Dimensions node undesirable behaviors #26

borupdaniel opened this issue Jan 16, 2020 · 2 comments

Comments

@borupdaniel
Copy link
Member

The dimensions node has numerous bugs and undesirable behavior.

The only repeatable issue I have is with the split functionality - given a new input, split will revert to N and 1. I think this has to do with how the validate function runs and adjusts the values to fit with the input data, but it is problematic when saving networks with Dimensions nodes, or when loading new data from a file in the same network.

(porting from @nckz on GitLab a while back)

@rkrobison
Copy link
Contributor

rkrobison commented Mar 25, 2020

It would take a substantial rewrite of the validate function to fix this issue. I have created a new Reshape node , which should hopefully address these issues.

@borupdaniel
Copy link
Member Author

Cool, thanks Ryan! I'll give that a try. Appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants