Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge - Able to chat with assistants about deleted knowledge file , if it was the last knowledge file that was deleted. #518

Open
sangee2004 opened this issue Sep 16, 2024 · 3 comments
Labels
bug Something isn't working knowledge

Comments

@sangee2004
Copy link

Electron build - d27f9f

Steps to reproduce the problem:

  1. Create an assistant
  2. Add 1 knowledge file using "Add Local Files"
  3. Chat with the assistant about this knowledge file.
  4. Edit the assistant and remove this knowledge file.
  5. Start a new chat with the assistant about the knowledge file (that was deleted)

User still gets responses for queries relating to the deleted knowledge file.

@sangee2004 sangee2004 added bug Something isn't working knowledge labels Sep 16, 2024
@cjellick
Copy link
Contributor

2 follow up questions:

  1. " if it was the last knowledge file that was deleted." whats the significance of this part? Does this mean if you deleted two files, the first one you deleted would be gone as expected?
  2. when you say "start a new chat" you mean a brand new thread, right?

@sangee2004
Copy link
Author

  1. "if it was the last knowledge file that was deleted." whats the significance of this part? Does this mean if you deleted two files, the first one you deleted would be gone as expected?
    If i had an assistant with 2 knowledge files and I deleted one of the knowledge file , I dont see this behavior when chatting in new threads. In this case we have an issue only when chatting in existing threads - Knowledge - Able to chat with deleted knowledge files in existing threads. #519
  2. when you say "start a new chat" you mean a brand new thread, right?
    Yes.

@iwilltry42
Copy link
Contributor

I guess this is a "bug" where the pruning doesn't actually happen because knowledge will noop out if there is no file at all.
Though I think my expectation would be that the dataset is being deleted and the knowledge tool removed from the assistant if the last file was removed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working knowledge
Projects
None yet
Development

No branches or pull requests

3 participants