Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add husky #5

Merged
merged 1 commit into from
Sep 24, 2020
Merged

chore: add husky #5

merged 1 commit into from
Sep 24, 2020

Conversation

pyphilia
Copy link
Contributor

No description provided.

Copy link
Member

@juancarlosfarah juancarlosfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one question: what is the react-app-env.d.ts file?

@@ -21,3 +21,7 @@ yarn-error.log*

# development environments
.idea/

# react-app-env
src/react-app-env.d.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, right?

@pyphilia
Copy link
Contributor Author

@juancarlosfarah From this issue facebook/create-react-app#6560 It is an automatically generated file because of typescript. It seems necessary yet it contains nothing. Many included it in gitignore, and since it generates automatically it should not be a problem. But we could also include it in the project, let me know what you think.

@juancarlosfarah
Copy link
Member

@pyphilia, no problem. Sounds like it should be ignored!

@juancarlosfarah juancarlosfarah merged commit 432ce71 into master Sep 24, 2020
@juancarlosfarah juancarlosfarah deleted the 4/husky branch September 24, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants