Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari buttons were not fixed #4034

Closed
1 task done
cowanAI opened this issue May 2, 2023 · 12 comments · Fixed by #4070
Closed
1 task done

Safari buttons were not fixed #4034

cowanAI opened this issue May 2, 2023 · 12 comments · Fixed by #4070
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cowanAI
Copy link

cowanAI commented May 2, 2023

Describe the bug

output text was fixed but not the button that look "off"

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

Same issue discussed as before

Screenshot

image

Logs

no logs

System Info

3.28.1, safari

Severity

annoying

@cowanAI cowanAI added the bug Something isn't working label May 2, 2023
@abidlabs
Copy link
Member

abidlabs commented May 2, 2023

Hmm @aliabid94 can you investigate? @cowanAI can you provide a full code example we can use to reproduce?

@abidlabs abidlabs added this to the 3.x milestone May 2, 2023
@cowanAI
Copy link
Author

cowanAI commented May 2, 2023

for sure:

ui = gr.Interface(
fn=transcribe,
theme='gradio/soft',
inputs=[
gr.Audio(source="microphone", type="filepath", label="Upload audio"),
gr.Textbox(label="Or chat here:"),

],
outputs=gr.Textbox(interactive=True,label="Alicja AI:").style(show_copy_button=True),
#allow_flagging=('never'),
examples=[    ["Medical_Transcriber.mp3", "Medical transcriber: Alicja, please summarize the patient visit and auto-fill the “X” form."],
["Medical_Writing.mp3", "Medical writing: Hey Alicja, can you help me organize my thoughts for this research paper?"],
["Clinical_Trials.mp3", "Clinical trials: Alicja, what is the recommended sample size for this clinical trial and can you help me analyze the results?"],
["Language_Translation.mp3", "Language translation: Alicja, can you help me translate what this patient is saying into English?"],
["Medical_Research.mp3", "Medical research: Hey Alicja, can you help me find some relevant literature for this research question?"],
["Patient_Education.mp3", "Patient education: Alicja, can you explain this medical condition to my patient in simple terms?"],

],
css="footer {visibility: hidden}",
allow_flagging=('never'),
)

ui.queue(concurrency_count=2)
app = gr.mount_gradio_app(app, ui, path=CUSTOM_PATH)

I think maybe it's because the bug was fixed for Safari mobile but not Safari Desktop maybe?

@abidlabs
Copy link
Member

abidlabs commented May 2, 2023

I think maybe it's because the bug was fixed for Safari mobile but not Safari Desktop maybe?

That's possible. Would you be able to check and see if that's the case? It would help us narrow down the possible culprit.

Also, which version of Safari Desktop are you using?

@cowanAI
Copy link
Author

cowanAI commented May 2, 2023

sure, doing right now and the version is Version 16.3 (18614.4.6.1.6) @abidlabs

@cowanAI
Copy link
Author

cowanAI commented May 2, 2023

@abidlabs used it on my phone and the issue is across all devices, but the text got fixed thanks for that

@cowanAI
Copy link
Author

cowanAI commented May 2, 2023

also tried it on google chrome mobile and it doesnt seem to be only a safari issue, it seems more like an apple related issue, although it doesnt work also on safari desktop the buttons

@cowanAI
Copy link
Author

cowanAI commented May 2, 2023

the desktop version looks 😍 though, but yes unfortunately the mobile just doesnt look good the buttons are "off"

image

@aliabid94
Copy link
Collaborator

aliabid94 commented May 4, 2023

Ah I see, so I fixed the soft theme in the library, but you're loading the soft theme from the theme from the online theme store. I need to update the theme online, but I'd recommend you use the theme from the library, e.g.

theme = gr.themes.Soft() # instead of "gradio/soft"

this way you don't need to load the theme from the internet, so it will be faster.

@aliabid94
Copy link
Collaborator

seems like a couples labelsare actually still grayed out actually, looking into it

@aliabid94
Copy link
Collaborator

Ok I fixed the grayed out labels in #4070, I've also already pushed the the theme hub so that should work well now.

@cowanAI
Copy link
Author

cowanAI commented May 4, 2023

thanks! @abidlabs in safari mobile as well? I'm currently on it and it looks grayed out, but if I need to redeploy let me know, thanks again
IMG_D13606DBAD64-1

@abidlabs
Copy link
Member

abidlabs commented May 4, 2023

@cowanAI I just checked on the branch on Safari Mobile and it's working well for me. You will need to redeploy yes, and you might even need to wait until we release on pypi (or install gradio from main by following the instructions here: https://gradio.app/docs/main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants