Remove explicit return types rule #5070
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm proposing we remove eslint's explicit function return types rule. We have quite a few of these errors around our repo (e.g
Dataset.svelte
) but can't fix these if the function is inline because Svelte can't parse non-standard JS expressions in the markup of the file without adding an external transpiler into the mix, it can only do so in the<script />
. The only way of resolving the error is moving the func to the<script />
but this isn't ideal, and I think we should just remove this rule to tidy up our errors. This is a known limitation. Also a discussion around it here.Open to discussion around this!