Refactor Cancelling Logic To Use /cancel #8370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/c2dd4a187c238295017c70526b6ddc1dd2c41238/gradio-4.33.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c2dd4a187c238295017c70526b6ddc1dd2c41238#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/c2dd4a187c238295017c70526b6ddc1dd2c41238/gradio-client-0.20.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
commented
May 24, 2024
| @@ -1916,7 +1904,7 @@ async def process_api( | |||
| ] | |||
| data, changed_state_ids = zip(*data_and_changed_state_ids) | |||
| if root_path is not None: | |||
| data = processing_utils.add_root_url(data, root_path, None) | |||
| data = processing_utils.add_root_url(data, root_path, None) # type: ignore | |||
There was a problem hiding this comment.
Removing the Any return type hint from postprocess_data makes pyright complain about this line. I think it does not understand the zip(*...) in line 1905.
freddyaboulton
force-pushed
the
cancel-refactor
branch
from
89cf0ab
to
fb9651c
Compare
freddyaboulton
requested review from
pngwn,
aliabid94 and
hannahblair
and removed request for
pngwn,
aliabid94 and
hannahblair
|
Bump @aliabid94 |
pngwn
approved these changes
Jun 4, 2024
|
Thanks everyone for the reviews! |
Merged
pngwn
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Cancel refactor * add changeset * add changeset * types * Add code * Fix types --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
pngwn
added a commit
that referenced
this pull request
Jun 6, 2024
…forms (#8451) * fix param name * format * save * changes * changes * fix param name * format * switch to async iterable interface * switch to async iterable interface * changes * add changeset * fix * fix param name * format * fixes * fix checks * fix checks * add changeset * fix checks * add changeset * add changeset * fix checks * fix param name * format * fix types * cleanup comments * add changeset * fix param name * format * changes * Refactor Cancelling Logic To Use /cancel (#8370) * Cancel refactor * add changeset * add changeset * types * Add code * Fix types --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * fix param name * format * changes * fix * fix param name * format * fix test * fix notebooks * fix type --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from #8260 comment. All the cancelling logic happens in
/cancelroute.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh