Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report useful error when no files at all exist #284

Closed
JLLeitschuh opened this issue Mar 4, 2020 · 2 comments
Closed

Report useful error when no files at all exist #284

JLLeitschuh opened this issue Mar 4, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers in:wrapper-validation
Milestone

Comments

@JLLeitschuh
Copy link
Contributor

If this action is run and a user forgets to add the - uses: actions/checkout@v2 they get this uninformative error:

Run gradle/wrapper-validation-action@v1
  with:
    wrapper-directory: gradle/wrapper
    gradle-executable: gradlew
    allow-snapshots: true
    min-wrapper-count: 1
##[error]Gradle Wrapper Validation Failed!
  See https://github.com/gradle/wrapper-validation-action#reporting-failures
✗ Other validation errors:
  Expected to find at least 1 Gradle Wrapper JARs but got only 0

We should provide a more useful error when the GitHub action is running in the context of no files at all so that there is a more actionable step that users can take.

@orchestr7
Copy link

For sure! it is very confusing, I was thinking for several days that the problem is with github actions

@JLLeitschuh JLLeitschuh added the good first issue Good for newcomers label May 17, 2021
@pu6karev
Copy link

pu6karev commented Mar 6, 2023

I have marked jar files in gitignore earlier. I removed this file type from gitignore and everything worked. Of course, added the specific gradle-wrapper.jar to repo.

@bigdaz bigdaz transferred this issue from gradle/wrapper-validation-action Jul 12, 2024
@bigdaz bigdaz added enhancement New feature or request in:wrapper-validation labels Jul 12, 2024
@bigdaz bigdaz closed this as completed in ac3aebd Aug 2, 2024
@bigdaz bigdaz added this to the v4.0.0 milestone Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in:wrapper-validation
Projects
None yet
Development

No branches or pull requests

5 participants
@bigdaz @JLLeitschuh @pu6karev @orchestr7 and others