Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete dependency-graph is submitted on build failure #43

Closed
bigdaz opened this issue Feb 13, 2024 · 1 comment
Closed

Incomplete dependency-graph is submitted on build failure #43

bigdaz opened this issue Feb 13, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
v3.1

Comments

@bigdaz
Copy link
Member

bigdaz commented Feb 13, 2024

When using gradle/actions/dependency-submission (or setup-gradle with dependency-graph enabled), a failing build can generate an empty or partial dependency graph. When this graph is submitted, it replaces the existing (correct) dependency graph, resolving any associated Dependabot Alerts.

We should only submit a dependency-graph when the generating build completes successfully.
@bigdaz bigdaz added this to the v3.1 milestone Feb 13, 2024
@bigdaz bigdaz added the bug Something isn't working label Feb 13, 2024
@bigdaz
Copy link
Member Author

bigdaz commented Feb 13, 2024

Fixed in 2262487

@bigdaz bigdaz closed this as completed Feb 13, 2024
@bigdaz bigdaz changed the title Incomplete dependency-graph submitted on build failure Incomplete dependency-graph is submitted on build failure Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
1 participant
@bigdaz