You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is useful for running tests in a sandbox environment where things like the network aren't available. We initially started doing this after @flokli's #333, which needs to skip over tests for NixOS.
However, adding the extra tag makes it more difficult to write the tests, as it is excluded from build by default, and therefore excluded from gopls by default.
I'd suggest that we invert the condition instead:
//go:build !nonetwork
//go:build !nodocker
(etc)
This makes it easier to add to the tests, and ensures that the default testing behavior is to run everything.
The text was updated successfully, but these errors were encountered:
Today, we have tests which only execute when
-tags has_network
is provided:agent/pkg/operator/kubelet_test.go
Line 3 in 727f908
This is useful for running tests in a sandbox environment where things like the network aren't available. We initially started doing this after @flokli's #333, which needs to skip over tests for NixOS.
However, adding the extra tag makes it more difficult to write the tests, as it is excluded from build by default, and therefore excluded from gopls by default.
I'd suggest that we invert the condition instead:
(etc)
This makes it easier to add to the tests, and ensures that the default testing behavior is to run everything.
The text was updated successfully, but these errors were encountered: