Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SIGHUP signal for config reloading #537

Closed
jpdstan opened this issue Apr 13, 2021 · 1 comment · Fixed by #710
Closed

Support SIGHUP signal for config reloading #537

jpdstan opened this issue Apr 13, 2021 · 1 comment · Fixed by #710
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@jpdstan
Copy link

jpdstan commented Apr 13, 2021

With the recent PR to add support for /-/reload endpoint, imo we should also allow for SIGHUP signals to follow the same codepath, such that we are consistent with Prometheus's config reloading.

Expected:
kill -HUP $(sudo supervisorctl pid grafana-agent) reloads the configuration

Actual
kill -HUP $(sudo supervisorctl pid grafana-agent) restarts the server completely
@rfratto rfratto added the size/m label Apr 13, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue/PR mark as stale due lack of activity label Jun 2, 2021
@rfratto rfratto added the keepalive Never close from staleness label Jun 2, 2021
@stale stale bot removed the stale Issue/PR mark as stale due lack of activity label Jun 2, 2021
@rfratto rfratto mentioned this issue Jul 6, 2021
Merged
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trigger reload configuration using SIGHUP tharun208/agent
2 participants
@rfratto @jpdstan