Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDB metrics update, metadata cache metrics #85

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Conversation

pstibrany
Copy link
Member

This PR modifies previous blocks metrics to reflect state on current Cortex master after cortexproject/cortex#2627. This PR also adds missing metrics for Metadata cache (from querier, and from store-gateway).

@pstibrany pstibrany requested a review from pracucci June 2, 2020 12:05
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please remember to merge and rollout only after we upgrade all envs.

@pstibrany pstibrany merged commit 4a540d2 into master Jun 9, 2020
@pstibrany pstibrany deleted the tsdb-metrics branch June 9, 2020 11:12
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
* Update TSDB metrics after recent change on Cortex master.

* Fix operation name.

* Added metadata cache stats (per querier and store-gateway).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants