Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kafka support #17

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Add Kafka support #17

merged 3 commits into from
Jan 18, 2024
+132 −16

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Jan 18, 2024 •
edited
Loading

In this PR I'm adding Kafka support. This will be used to test the new experimental ingest storage in Mimir.

Notes:

  • I've used franz-go Kafka client to run the readiness check, because I haven't found a reliable way to do it without using the Kafka protocol (e.g. just checking the 9092 port is open is not enough)
  • I've upgraded to golang 1.19, which is required by a franz-go dependency (klauspost/compress)

@pracucci
Add Kafka support
6596269 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci mentioned this pull request Jan 18, 2024
Merged
4 tasks
@pracucci
Explicit call to SetEnvVars()
8eb354c 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Upgrade golang to 1.19
e8dca9b 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit db90b84 into main Jan 18, 2024
4 checks passed
@pracucci pracucci deleted the add-kafka branch January 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pracucci @pstibrany