From 628705918d3bf8b038c20eba6373cb594db379e0 Mon Sep 17 00:00:00 2001 From: Marc Mignonsin Date: Thu, 6 Feb 2025 11:01:29 +0100 Subject: [PATCH 1/2] fix(Settings): Prevent warning to be displayed when no settings have been returned by the Settings API --- src/shared/infrastructure/settings/settingsApiClient.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/shared/infrastructure/settings/settingsApiClient.ts b/src/shared/infrastructure/settings/settingsApiClient.ts index 67e4209b..dd09e0fb 100644 --- a/src/shared/infrastructure/settings/settingsApiClient.ts +++ b/src/shared/infrastructure/settings/settingsApiClient.ts @@ -13,14 +13,10 @@ class SettingsApiClient extends ApiClient { .fetch('/settings.v1.SettingsService/Get', { method: 'POST', body: JSON.stringify({}) }) .then((response) => response.json()) .then((json: ApiResponse) => { - if (!json.settings) { - return {}; - } - - const setting = json.settings.find(({ name }) => name === SettingsApiClient.PLUGIN_SETTING_NAME); + const setting = json.settings?.find(({ name }) => name === SettingsApiClient.PLUGIN_SETTING_NAME); if (!setting) { - throw new Error('Setting not found!'); + return {}; } return JSON.parse(setting.value); From 5e02796c6ace5ea7e662d15601bda65affd47429 Mon Sep 17 00:00:00 2001 From: Marc Mignonsin Date: Thu, 6 Feb 2025 11:49:29 +0100 Subject: [PATCH 2/2] build(*): Trigger Build