Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sdk meta optional to not waste payload size #305

Closed
codecapitano opened this issue Oct 12, 2023 · 0 comments · Fixed by #370
Closed

Make sdk meta optional to not waste payload size #305

codecapitano opened this issue Oct 12, 2023 · 0 comments · Fixed by #370
Labels
improvement Request a change of an existing feature

Comments

@codecapitano
Copy link
Collaborator

Description

The sdk meta adds data about the Web-SDK and the configured instrumentations.
This information can be useful for debugging purposes , but isn't of any value when it comes to Real User Monitoring (RUM).

So it unnecessarily adds bytes to each requests payload which we should avoid.

Proposed solution

Remove the meta completely or make it optional and disable by default

Context

See question in discussions area
@codecapitano codecapitano added the improvement Request a change of an existing feature label Oct 12, 2023
@codecapitano codecapitano mentioned this issue Nov 6, 2023
Merged
3 tasks
@codecapitano codecapitano linked a pull request Nov 6, 2023 that will close this issue
change: remove sdk meta from default metas #370
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Request a change of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change: remove sdk meta from default metas grafana/faro-web-sdk
1 participant
@codecapitano