Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin disabled due to modified content #304

Closed
jgarciadelanoceda opened this issue Nov 11, 2021 · 7 comments
Closed

Plugin disabled due to modified content #304

jgarciadelanoceda opened this issue Nov 11, 2021 · 7 comments

Comments

@jgarciadelanoceda
Copy link

What happened:
We installed last Grafana (8.2.2) version in a Windows Server and we installed this plugin using admin/plugins.
We observed that when we stop the Windows Grafana Service sometimes we find this message
image

What you expected to happen:
To do not have problems when restarting grafana service

How to reproduce it (as minimally and precisely as possible):

Have a Grafana service in a Windows machine with this plugin installed. Restart the service several times.

Anything else we need to know?:

Environment:

  • Grafana Image Renderer version:3.2.1
  • Grafana version:8.2.2
  • Installed plugin or remote renderer service:Installed plugin
  • OS Grafana Image Renderer is installed on:Windows
  • User OS & Browser:Chrome
  • Others:
@Maplesoup
Copy link

+1 to this, getting the same issue.

If installed via cli grafana won't even start

@mattkosonen
Copy link

Same issue here. I have it installed on a Windows machine as well.

@Maplesoup
Copy link

Quick fix for this is to install 3.2.0 instead. If you are using the grafana cli you can add a version as the last arguement for the install command.

@AgnesToulet
Copy link
Contributor

Hello! Thank you for reporting this. Can you share your Grafana logs when restarting Grafana and seeing the plugin disabled?
Also, it's very surprising that downgrading to 3.2.0 is fixing the issue, @Maplesoup could you try the latest plugin version as well please? (3.3.0)

@jgarciadelanoceda
Copy link
Author

jgarciadelanoceda commented Nov 30, 2021

Hello,

I reproduce it again with version 3.3.0 (I did not tried to do it with version 3.2.0 though)

I attach you the log
grafana.log

As you can see at 13:22 I installed the plugin via web.
At 13:24 I tried to render a image but as I did not stop Grafana to load the plugin it failed so I restarted Grafana at 13:25
At 13:26 I rendered an image and seconds later I rendered another but stop Grafana service.

You can see that at 13:27 grafana-image-renderer has a modified signature so the plugin does not start.

image

Something that it is also noticiable is that if you download the zip File via grafana Api you get a folder named plugin-win32-x64-unknown that is something that is weird for me.

I download all the plugins via this script(It is a Powershell file but you can see the logic inside)

DownloadPlugins.txt

@jgarciadelanoceda
Copy link
Author

@AgnesToulet info already added

@AgnesToulet
Copy link
Contributor

Thanks for the logs! This is the same issue as #260 and it's fixed in Grafana 9.4.0 (grafana/grafana#59104).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants