Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status conditions to all objects #1450

Open
2 of 4 tasks
theSuess opened this issue Mar 12, 2024 · 2 comments
Open
2 of 4 tasks

Add status conditions to all objects #1450

theSuess opened this issue Mar 12, 2024 · 2 comments
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@theSuess
Copy link
Member

theSuess commented Mar 12, 2024

Kubernetes status conditions are the way to go, especially regarding automated healtchecks (see #1444).

While the new alert rule group CR already supports this, we need to implement status conditions for the remaining resources.

Tasks

Preview Give feedback
@theSuess theSuess added enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 12, 2024
@NissesSenap
Copy link
Collaborator

Currently, the other controllers are writing lots of data to statuses to make sure things can get deleted.
If we instead go over to using finalizers, many of these statuses should be able to be removed.

So when wen doing this refactor, I would also consider adding the finalizers to the other controllers.

@theSuess
Copy link
Member Author

I'd tackle it one at a time to keep PRs small and the error potential low. First adding the extra status field and then removing other ones. That way we can also release a version with conditions faster without including breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants