Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSource needs to be managed through grafana API #655

Closed
guimou opened this issue Dec 15, 2021 · 7 comments
Closed

DataSource needs to be managed through grafana API #655

guimou opened this issue Dec 15, 2021 · 7 comments
Labels
feature-request requests a new feature that currently isn't implemented in the project triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@guimou
Copy link

guimou commented Dec 15, 2021

Hi!
When creating a DataSource through OpenShift Advanced Cluster Management, ACM, the datasource does not work. Other components (dashboard, Grafana instance works well).
The exact same deployment through an oc apply -k (like what ACM is doing) works perfectly.

We were able to pinpoint the problem. ACM is adding this in the GrafanaDataSource CR metadata:

ownerReferences:
  - apiVersion: apps.open-cluster-management.io/v1
    kind: Subscription
    name: grafana-ramendemo-configuration-subscription-1-local
    uid: b0b00735-ac72-4b10-bc6d-a88972feec6a

When the ownerReferences section is removed manually, the operator picks up the DataSource and refreshes the deployment.

Version
3.10.3

To Reproduce
Create a datasource with the standard YAML config, and apply it through an ACM deployment.

Expected behavior
Datasource is picked up by the operator regarless of owner information.

Runtime (please complete the following information):

  • Grafana Operator Version: 3.10.3
  • Environment: Openshift 4.8
  • Deployment type: Operator deployed, using ACM to create Grafana resources
@guimou guimou added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2021
@NissesSenap
Copy link
Collaborator

@guimou can you please try version 4.1.0 (4.1.1) will be released soon instead.
Not that I think it will help but we will most likely not backport any fix around this issue to v3 so you will have to upgrade to v4 no matter what.

@NissesSenap
Copy link
Collaborator

If it works with dashboard but not with datasource it's probably thanks to that we are using a configmap to insert the datasource.

As mentioned in: #652 We should ideally start using the http API to interact with data sources
So that would probably solve this issue while remove some technical debt.

@github-actions
Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Jan 15, 2022
@pb82
Copy link
Collaborator

pb82 commented Jan 18, 2022

@guimou we expect to fix this when switching to the API for data sources.

@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. stale labels Jan 18, 2022
@guimou
Copy link
Author

guimou commented Jan 18, 2022

OK, no worries. Do you want to leave this open til then, or do we close it?

@NissesSenap
Copy link
Collaborator

We will keep it open, it's a good way to track it.

@NissesSenap NissesSenap changed the title DataSource deployed through ACM is not picked up DataSource needs to be managed through grafana API Apr 26, 2022
@NissesSenap NissesSenap added the feature-request requests a new feature that currently isn't implemented in the project label Apr 26, 2022
@NissesSenap NissesSenap added feature-request requests a new feature that currently isn't implemented in the project v5 and removed feature-request requests a new feature that currently isn't implemented in the project bug Something isn't working labels May 3, 2022
@NissesSenap NissesSenap added this to the Version 5.0 milestone Mar 8, 2023
@hubeadmin
Copy link
Collaborator

Resolved in #919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request requests a new feature that currently isn't implemented in the project triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants