Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata info panel #3304

Merged
merged 6 commits into from
Dec 15, 2015
Merged

Added metadata info panel #3304

merged 6 commits into from
Dec 15, 2015

Conversation

utkarshcmu
Copy link
Collaborator

Currently, info show created and updated time. But in the future it can show created by and updated by fields too. Also, this dropdown can be extended to show some other info also in the future.

@utkarshcmu
Copy link
Collaborator Author

This PR adds some features requested in #3047

@utkarshcmu
Copy link
Collaborator Author

Hover on info icon:
screen shot 2015-11-21 at 6 37 05 am

Click on info icon:
screen shot 2015-11-21 at 6 44 14 am

@torkelo
Copy link
Member

torkelo commented Nov 21, 2015

not sure this deserves a top bar icon, maybe have the info in the dashboard settings

@utkarshcmu
Copy link
Collaborator Author

Thanks for the review, will make the change asap.

@utkarshcmu
Copy link
Collaborator Author

@torkelo Removed the top bar icon and included metadata in settings dropdown

@utkarshcmu
Copy link
Collaborator Author

New snapshots:

screen shot 2015-11-21 at 7 35 52 pm

screen shot 2015-11-21 at 7 35 57 pm

We will be putting more information(created by, updated by, etc) in metadata in the future so it is better to have a separate view for it as show above. :)

@utkarshcmu utkarshcmu mentioned this pull request Nov 22, 2015
@utkarshcmu
Copy link
Collaborator Author

Haha, finally I can access this PR :)

@torkelo Please review/merge this PR. Thanks.

@utkarshcmu utkarshcmu changed the title Added dashboard info dropdown Added metadata info panel Nov 22, 2015
@utkarshcmu
Copy link
Collaborator Author

Is there anything else I can do to get this PR merged? Would be great if we can get this info available in the next release.

Anyway, the next step in this direction will be adding Created by and Updated by fields. :)

@torkelo
Copy link
Member

torkelo commented Dec 2, 2015

I was thinking that this info would go under a dashboard settings tab, and not a in the settings menu

@utkarshcmu
Copy link
Collaborator Author

screen shot 2015-12-02 at 4 18 08 am

Done. Please review/merge.

@utkarshcmu
Copy link
Collaborator Author

Should I add dashboard Id also or this information is sufficient right now to get this feature rolled out?

@utkarshcmu
Copy link
Collaborator Author

@torkelo Will this feature go into 2.6?

@Qtax
Copy link
Contributor

Qtax commented Dec 5, 2015

@utkarshcmu the format is hard coded? I would at least prefer the international ISO 8601 format (24h time).

Otherwise this is good information to have accessable.

@utkarshcmu
Copy link
Collaborator Author

@Qtax yes the format is hardcoded right now. We can change it to whtever we want to. I am fine with any format if it shows up to a second's granularity. My main goal for this PR is to know when are these dashboards last modified and when were they created. Which will help us maintaining 100s of dashboards. The next step after this PR will be , who created them and who updated them. I ll try to include these two fields too asap in the same panel as time permits.

@utkarshcmu
Copy link
Collaborator Author

@torkelo What do you think about the hard coded format?

@bergquist
Copy link
Contributor

The placement of such info is hard. If more info are to be added I think a special tab for it makes sense.

bergquist added a commit that referenced this pull request Dec 15, 2015
Added metadata info panel
@bergquist bergquist merged commit 2b58b6b into grafana:master Dec 15, 2015
@utkarshcmu utkarshcmu deleted the info branch December 15, 2015 18:41
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants