Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL: Add option to allow cleartext passwords #63232

Merged
merged 6 commits into from
May 26, 2023
Merged

MySQL: Add option to allow cleartext passwords #63232

merged 6 commits into from
May 26, 2023

Conversation

enginecan
Copy link
Contributor

@enginecan enginecan commented Feb 10, 2023 •
edited by zoltanbedi

Adds "Allow Cleartext Passwords" checkbox to MySQL connection settings page in order to enable support for Cleartext Passwords

image

Rework of #30112 Fixes #37010

@enginecan enginecan requested a review from a team February 10, 2023 02:27
@enginecan enginecan requested a review from a team as a code owner February 10, 2023 02:27
@enginecan enginecan requested review from codeincarnate, oscarkilhed, zserge, mildwonkey and yangkb09 and removed request for a team February 10, 2023 02:27
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@enginecan enginecan mentioned this pull request Feb 10, 2023
Closed
@gannaramu
Copy link

also addresses #37010

@codeincarnate codeincarnate changed the title Fixes issue #30112 MySql Datasource: Add Option to Allow Cleartext Passwords Feb 21, 2023
@grafanabot
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@grafanabot grafanabot added stale Issue with no recent activity and removed stale Issue with no recent activity labels Mar 24, 2023
@zoltanbedi
Copy link
Member

Hey @enginecan,
Thanks for creating this PR. Are you interested in wrapping this up? Maybe I can help you with something?

@enginecan
Copy link
Contributor Author

Hey @zoltanbedi, I've solved the merge conflicts. Feel free to review...

@zoltanbedi
Copy link
Member

Thanks @enginecan,
Looks like the CI is failing on lint issues please resolve those and this new option needs to be added to the documentation as well. Can you please do those?

@zoltanbedi zoltanbedi added this to the 10.0.0 milestone Apr 18, 2023
@enginecan
Copy link
Contributor Author

enginecan commented May 3, 2023 •
edited

@zoltanbedi - Could you please fix those issues? I don't have enough time to look into linting issues.

@zoltanbedi
Copy link
Member

@enginecan yep I can continue.

@zoltanbedi zoltanbedi self-assigned this May 11, 2023
@zoltanbedi zoltanbedi changed the title MySql Datasource: Add Option to Allow Cleartext Passwords MySQL: Add option to allow cleartext passwords May 17, 2023
@zoltanbedi zoltanbedi modified the milestones: 10.0.0, 10.1.x May 24, 2023
@zoltanbedi zoltanbedi requested a review from mdvictor May 24, 2023 08:53
lwandz13
lwandz13 approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@lwandz13 lwandz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdvictor
mdvictor approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@mdvictor mdvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

baldm0mma
baldm0mma approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoltanbedi
Copy link
Member

Thanks for your contribution @enginecan!

@zoltanbedi zoltanbedi merged commit 6758fd4 into grafana:main May 26, 2023
12 checks passed
grobinson-grafana pushed a commit that referenced this pull request May 31, 2023
@enginecan @zoltanbedi @grobinson-grafana
MySQL: Add option to allow cleartext passwords (#63232)
73164a0 
* Add "Allow Cleartext Passwords" checkbox to MySQL connection settings

* Fix lint issues

* Add docs

* Add line break and bold text

---------

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
@enginecan
Copy link
Contributor Author

Thanks for your contribution @enginecan!

Likewise, thanks for creating this great tool!

@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi left review comments

@baldm0mma baldm0mma baldm0mma approved these changes

@mdvictor mdvictor mdvictor approved these changes

@lwandz13 lwandz13 lwandz13 approved these changes

@codeincarnate codeincarnate Awaiting requested review from codeincarnate

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

@Eve832 Eve832 Awaiting requested review from Eve832

@GrafanaWriter GrafanaWriter Awaiting requested review from GrafanaWriter

Assignees

@zoltanbedi zoltanbedi

Labels
add to changelog area/backend area/frontend datasource/MySQL no-backport Skip backport of PR pr/external This PR is from external contributor type/docs
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@enginecan @CLAassistant @gannaramu @grafanabot @zoltanbedi @mdvictor @baldm0mma @lwandz13 @ricky-undeadcoders