Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add clear search button to the input bar #66204

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Apr 9, 2023

This PR fixes #65705

What is this feature for?

Adds clear search button for dashboard

Pasted image 20230409174711

@khushijain21 khushijain21 requested a review from a team as a code owner April 9, 2023 13:27
@khushijain21 khushijain21 requested review from joshhunt and ashharrison90 and removed request for a team April 9, 2023 13:27
@grafanabot grafanabot added area/frontend pr/external This PR is from external contributor labels Apr 9, 2023
@JoaoSilvaGrafana JoaoSilvaGrafana added this to the 10.0.0 milestone Apr 10, 2023
@JoaoSilvaGrafana JoaoSilvaGrafana changed the title Dashboard: Add clear search button to the input bar Search: Add clear search button to the input bar Apr 10, 2023
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this looks good 👏

Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoaoSilvaGrafana JoaoSilvaGrafana merged commit 4ba7c48 into grafana:main Apr 10, 2023
6 checks passed
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/search no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: Add clear search button to the input bar
4 participants