Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveTable: Updated design and minor tweak to Correlactions page #66443

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 13, 2023

In an effort to align table designs I propose we make this change to the InterativeTable to make it look better and more inline with other tables.

  • Remove table header background (standard Table component does not have this)
  • Remove the surrounding border (Feels unnecessary, placing the table inside a box with border feels like should be up to each use case and not part of the component itself).
  • Add row hover highlight (Same as we have with standard Table component)
  • Remove striped rows and just use border separator for all rows (it's the same in standard Table)
  • For expanded rows we don't show the bottom border, and we add a left border to make the expanded content more connected to the expanded row.
  • Improve indentation of the expanded row content

Fixes

  • Issue with bad background for even rows where forms where placed on a background they were not designed for (Correlations edit form).
  • Better add button placement on the correlations page

Before:
Screenshot from 2023-04-13 11-40-05

After:
Screenshot from 2023-04-13 11-31-20

Also tweaks some things on the correlations page

  • Use Page subtitle for the paragraph below instead of the two page descriptions
  • Place add button in the top right corner (Page actions slot)

Correlations table question

  • Think it would make sense to move the "Read only" label to be the last column instead of first

@torkelo torkelo requested review from a team as code owners April 13, 2023 09:38
@torkelo torkelo requested review from joshhunt and yaelleC and removed request for a team April 13, 2023 09:38
@torkelo torkelo requested review from Elfo404 and removed request for joshhunt and yaelleC April 13, 2023 09:40
@torkelo torkelo added this to the 10.0.0 milestone Apr 13, 2023
@Elfo404
Copy link
Member

Elfo404 commented Apr 13, 2023

not sure why, but it renders like this for me (both on FF and chrome)

Screenshot 2023-04-13 at 11 08 09

@torkelo
Copy link
Member Author

torkelo commented Apr 13, 2023

@Elfo404 fixed it! lol, just before pushing I moved some styles for the expanded row from being at the bottom to the top of css class and I moved it too far up, outside the td selector :)

Copy link
Member

@Elfo404 Elfo404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so happy to see the zebra styles die ❤️

@github-actions
Copy link
Contributor

Backend code coverage report for PR #66443
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #66443

Plugin Main PR Difference
correlations 90.9% 90.93% .03%

@torkelo torkelo added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes add to changelog area/grafana/ui Issues that belong to components in the @grafana/ui library and removed no-changelog Skip including change in changelog/release notes labels Apr 13, 2023
@torkelo torkelo merged commit 4796a63 into main Apr 13, 2023
18 checks passed
@torkelo torkelo deleted the interactive-table-style branch April 13, 2023 13:50
alexmobo pushed a commit that referenced this pull request Apr 14, 2023
#66443)

* InteractiveTable: Updated design

* Fix css issue

* Fixed test

* Removed leftover
@zerok zerok removed this from the 10.0.0 milestone May 31, 2023
@zerok zerok added this to the 10.0.0-preview milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants