Search: Preserves search filters when navigating to another page #67021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigating to dashboard from search should not clear the filters
khushijain21
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team
Comment on lines
254
to
257
| // Clear some filters only if we're not opening a search item in a new tab | ||
| if (!e.altKey && !e.ctrlKey && !e.metaKey) { | ||
| this.setState({ tag: [], starred: false, sort: undefined, query: '', folderUid: undefined }); | ||
| } | ||
| // if (!e.altKey && !e.ctrlKey && !e.metaKey) { | ||
| // this.setState({ tag: [], starred: false, sort: undefined, query: '', folderUid: undefined }); | ||
| // } |
There was a problem hiding this comment.
Should just remove all these comments, otherwise it works as expected 👍
joshhunt
changed the title
|
@khushijain21 could you merge grafana:main back to your branch? This might solve the issue with failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this PR fix?:
This PR fixes #65710
Who is this feature for?
Navigating to dashboard from search should not clear the filters