Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query History: Remove migration #67470

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

Elfo404
Copy link
Member

@Elfo404 Elfo404 commented Apr 28, 2023

What is this feature?

Removes migration endpoint & frontend code for query history migrations.
This is listed as a breaking change because of the removal of the /query-history/migrate endpoint, but users should experience no changes.

Starting from Grafana 10, qury history entries saved in local storage (which happened in previous versions of grafana by default, or when query_history is disabled) will not be automatically migrated to remote storage.

Which issue(s) does this PR fix?:

Fixes #65792

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Release notice breaking change

The /query-history/migrate endpoint has been removed and query history entries will not be automatically migrated when switching from local storage to remote storage.

@Elfo404 Elfo404 added add to changelog breaking change Relevant for changelog generation no-backport Skip backport of PR labels Apr 28, 2023
@Elfo404 Elfo404 added this to the 10.0.0 milestone Apr 28, 2023
@grafanabot grafanabot added area/explore type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project area/frontend area/backend labels Apr 28, 2023
@Elfo404 Elfo404 marked this pull request as ready for review April 28, 2023 07:38
@Elfo404 Elfo404 requested review from a team and Eve832 as code owners April 28, 2023 07:38
@Elfo404 Elfo404 requested review from zserge, mildwonkey, suntala, tskarhed and JoaoSilvaGrafana and removed request for a team April 28, 2023 07:38
@github-actions
Copy link
Contributor

Backend code coverage report for PR #67470

Plugin Main PR Difference
queryhistory 82.9% 82.8% -.1%

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #67470

Plugin Main PR Difference
explore 86.34% 86.34% 0%

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice diff! Also I just realized how much code was there for migration. :D

@Elfo404 Elfo404 merged commit b5a2c3c into main Apr 28, 2023
@Elfo404 Elfo404 deleted the gio/chore/remove-query-history-migration branch April 28, 2023 15:03
ryantxu pushed a commit that referenced this pull request May 3, 2023
@zerok zerok removed this from the 10.0.0 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/explore area/frontend breaking change Relevant for changelog generation no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query history: Remove migration & migrate endpoint for Grafana v10
4 participants