Google Cloud Monitor: Fix mem usage for dropdown #67683
Conversation
Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters.
asimpson
added
backport v9.4.x
|
Hello @asimpson!
Please, if the current pull request addresses a bug fix, label it with the |
1 similar comment
|
Hello @asimpson!
Please, if the current pull request addresses a bug fix, label it with the |
asimpson
requested review from
aangelisc and
alyssabull
and removed request for
a team
|
Backend code coverage report for PR #67683 |
|
Frontend code coverage report for PR #67683
|
@aangelisc Oh, I think this is because I didn't set |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-67683-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b2e1b3ad91456fc70b407a52c552b718cfa7890c
# Push it to GitHub
git push --set-upstream origin backport-67683-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-67683-to-v9.4.xThen, create a pull request where the |
grafanabot
added
the
backport-failed
* Google Cloud Monitor: Fix mem usage for dropdown Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters. * fix: update tests for AsyncSelect * fix lint * fix: add subset of metrics on initial load (cherry picked from commit b2e1b3a)
Google Cloud Monitor: Fix mem usage for dropdown (#67683) * Google Cloud Monitor: Fix mem usage for dropdown Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters. * fix: update tests for AsyncSelect * fix lint * fix: add subset of metrics on initial load (cherry picked from commit b2e1b3a) Co-authored-by: Adam Simpson <adam@adamsimpson.net>
Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters. * fix: update tests for AsyncSelect * fix lint * fix: add subset of metrics on initial load
Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters. * fix: update tests for AsyncSelect * fix lint * fix: add subset of metrics on initial load
Previously the Metric name dropdown would attempt to load all the available metric names into the
Selectwhich would eventually crash the browser if the dataset was large enough.We can fix this by using
AsyncSelectand making another query once a Service is selected and the user types a few characters.Which issue(s) does this PR fix?:
#67682