A11y: Do not force colors in the color swatch and icon series #70862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Show the colors in the Color Swatch and the Icon Series when the Windows High Contrast mode is active.
When
forced-colors
is active, all shadows are removed. That is why the color swatch appears to be empty.Grafana relies on colors to display data, when the High Contrast mode is on it still makes sense to display custom colors in some cases.
This PR addresses the
ColorSwatch
and theSeriesIcon
components so a user with High Contrast mode can still interact with the data visualization colors.Before
before-high-contrast-color-picker.mov
After
after-high-contrast-color-picker.mov
Fixes #66311
Special notes for your reviewer:
If you don't have a Windows machine, you can emulate the same behavior with Chrome.
Open dev tools, cmd+shift+P, type rendering, change
Emulate CSS media feature forced-colors
toactive
Please check that: